AG-11385 Remove HTMLElements from the DOM

ag-grid · May 15, 2024 · b9f5260 · b9f5260
1 parent 36a0753
commit b9f5260
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/packages/ag-charts-community/src/chart/legend.ts b/packages/ag-charts-community/src/chart/legend.ts
@@ -277,6 +277,7 @@ export class Legend extends BaseProperties {
         this.destroyFns.forEach((f) => f());
 
         this.pagination.destroy();
+        this.itemSelection.clear();
     }
 
     public onMarkerShapeChange() {

diff --git a/packages/ag-charts-community/src/chart/markerLabel.ts b/packages/ag-charts-community/src/chart/markerLabel.ts
@@ -33,6 +33,11 @@ export class MarkerLabel extends Group {
         this.append([this.symbolsGroup, label]);
     }
 
+    override destroy() {
+        super.destroy();
+        this.proxyButton?.remove();
+    }
+
     proxyButton?: HTMLButtonElement;
 
     @ProxyPropertyOnWrite('label')

diff --git a/packages/ag-charts-community/src/scene/node.ts b/packages/ag-charts-community/src/scene/node.ts
@@ -319,6 +319,10 @@ export abstract class Node extends ChangeDetectable {
         this.zIndex = zIndex ?? 0;
     }
 
+    destroy(): void {
+        this.parent?.removeChild(this);
+    }
+
     containsPoint(_x: number, _y: number): boolean {
         return false;
     }

diff --git a/packages/ag-charts-community/src/scene/selection.ts b/packages/ag-charts-community/src/scene/selection.ts
@@ -131,7 +131,7 @@ export class Selection<TChild extends Node = Node, TDatum = any> {
             if (this.garbageBin.has(node)) {
                 this._nodesMap.delete(node);
                 this.garbageBin.delete(node);
-                this.parentNode.removeChild(node);
+                node.destroy();
                 return false;
             }
             return true;