Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Pagination #5

Closed
amcdnl opened this issue Mar 6, 2015 · 20 comments
Closed

[FEAT] Pagination #5

amcdnl opened this issue Mar 6, 2015 · 20 comments

Comments

@amcdnl
Copy link

amcdnl commented Mar 6, 2015

Virtual/Infinite scrolling is awesome but sometimes you need to give perspective to where you are at in the actual page structure so a user can leave and come back and easily find the item they were viewing.

I've implemented something like this on https://github.com/Swimlane/ng-table but I'd love to work with you to integrate this into your grid to make the ultimate grid! :)

@ceolter
Copy link
Contributor

ceolter commented Mar 6, 2015

Interesting. Am in pub at the mo. Will check out ng-table over the weekend.

Where you based??
On 6 Mar 2015 18:39, "Austin" notifications@github.com wrote:

Virtual/Infinite scrolling is awesome but sometimes you need to give
perspective to where you are at in the actual page structure so a user can
leave and come back and easily find the item they were viewing.

I've implemented something like this on
https://github.com/Swimlane/ng-table but I'd love to work with you to
integrate this into your grid to make the ultimate grid! :)


Reply to this email directly or view it on GitHub
#5.

@amcdnl
Copy link
Author

amcdnl commented Mar 6, 2015

The demo doesn't work that great but you can review the code. I'm working on getting it better but i use it internally fine.

It has jqueryui dependency i'd love to remove and has some missing features and it can be slowish sometimes hints why interested in your project.

The really cool thing about it is its directive driven!

I'm based in South Florida, US

@ceolter
Copy link
Contributor

ceolter commented Mar 6, 2015

Ah Florida, I am 5 or 6 hours ahead of you in London!!
On 6 Mar 2015 18:54, "Austin" notifications@github.com wrote:

The demo doesn't work that great but you can review the code. I'm working
on getting it better but i use it internally fine.

It has jqueryui dependency i'd love to remove and has some missing
features and it can be slowish sometimes hints why interested in your
project.

The really cool thing about it is its directive driven!

I'm based in South Florida US


Reply to this email directly or view it on GitHub
#5 (comment).

@amcdnl amcdnl changed the title Pagination [FEAT ]Pagination Mar 8, 2015
@amcdnl amcdnl changed the title [FEAT ]Pagination [FEAT] Pagination Mar 8, 2015
@ghost
Copy link

ghost commented Mar 25, 2015

Hi, ceolter ! I have checked your “Angular Grid”, It is greate! but the example does not have "Client side Pagination"?? which I think is the basic functions of a grid. I hope that I can found this function soon. Now I'm trying it...

@ceolter
Copy link
Contributor

ceolter commented Mar 25, 2015

Hi Ppneo, this feature isn't in yet, on my to do list. However the grid can handle very large data sets (tested up to 100k rows), why do you need pagination, why not load everything into the GUI and allow user to filter?

@amcdnl
Copy link
Author

amcdnl commented Mar 25, 2015

@ceolter I'm not sure throwing 100k is a good suggestion, maybe should give a demonstration on how to server side page based on scroll position and grid height.

@ceolter
Copy link
Contributor

ceolter commented Mar 25, 2015

lazy loading of rows based on scroll wasn't something i had in mind, grid doesn't support it :( . . . . but am curious what the use case is for paging - if your report has more than 1000 rows, then the user is not going to go through each row of the report, typically they would filter / search / aggregate (either in the client or the server). my gut feeling is paging is from old-style applications, where you couldn't handle large data sets in the client. one of the strong points of angular grid is you can manage large datasets, and filter / aggregate you way through it!

@amcdnl
Copy link
Author

amcdnl commented Mar 25, 2015

I think @ceolter sees the light after our discussion on gitter ;) ... @PPNeo you should join our discussions on gitter

@sheymann
Copy link

sheymann commented Apr 1, 2015

+1

1 similar comment
@sequoiar
Copy link

sequoiar commented Apr 1, 2015

+1

@hjzheng
Copy link

hjzheng commented Apr 8, 2015

+1

@ghost
Copy link

ghost commented Apr 10, 2015

+9001

(:D)

@ceolter
Copy link
Contributor

ceolter commented Apr 10, 2015

it's coming it's coming!!!

@nelreina
Copy link

I am with you ceolter. I don't see the point for pagination neither

@ceolter
Copy link
Contributor

ceolter commented Apr 11, 2015

Yeay!!!! At least one other person agrees with me!!!! Thanks Nelreina!!

Unfortunately (for me!!) I'm still having to implement it, even if I'm
never going to use it myself!!!

I have the core of pagination and infinite scrolling working now, I'm just
patching it all up before merging into trunk. Will probably be in this
weekend.

On 11 April 2015 at 16:34, nelreina notifications@github.com wrote:

I am with you ceolter. I don't see the point for pagination neither


Reply to this email directly or view it on GitHub
#5 (comment).

The information transmitted is intended only for the person or entity to
which it is addressed and may contain confidential and/or privileged
material. Statements and opinions expressed in this e-mail may not
represent those of the sender. Any review, retransmission, dissemination or
other use of, or taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is prohibited. If you
received this in error, please contact the sender immediately and delete
the material from any computer.

@sheymann
Copy link

@ceolter I'll give you a use case:

Fill in the table with results coming from a paginated search (e.g. using ElasticSearch), because you hell don't want to load large bulks of data. In general, pagination is recommended for goal-oriented finding tasks.

Sources:

Don't also forget that providing an infinite scroll feature is more difficult than what you think, because it's not "just" infinite scrolling but also much more features to make it usable:

@ceolter
Copy link
Contributor

ceolter commented Apr 11, 2015

so-you-think-you-built-good-infinite
http://blog.adrianroselli.com/2014/05/so-you-think-you-built-good-infinite.html
.
. . . . just read!!! . . . . mostly concerned about scrolling a webpage
though, not a grid.

funny, everyone else just asked for pagination, you asked for the best one
in the world!!!!

baby steps, baby steps, give my first iteration a try when it's ready :)

On 11 April 2015 at 17:37, Sébastien Heymann notifications@github.com
wrote:

@ceolter https://github.com/ceolter I'll give you a use case:

Fill in the table with results coming from a paginated search (e.g. using
ElasticSearch), because you hell don't want to load large bulks of data. In
general, pagination is recommended for goal-oriented finding tasks.

Sources:

Don't also forget that providing an infinite scroll feature is more
difficult than what you think, because it's not "just" infinite scrolling
but also much more features to make it usable:

http://blog.adrianroselli.com/2014/05/so-you-think-you-built-good-infinite.html


Reply to this email directly or view it on GitHub
#5 (comment).

The information transmitted is intended only for the person or entity to
which it is addressed and may contain confidential and/or privileged
material. Statements and opinions expressed in this e-mail may not
represent those of the sender. Any review, retransmission, dissemination or
other use of, or taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is prohibited. If you
received this in error, please contact the sender immediately and delete
the material from any computer.

@sheymann
Copy link

@ceolter I can't wait for it ;)

@ceolter
Copy link
Contributor

ceolter commented Apr 12, 2015

ok pagination and infinite scrolling is in! going to leave this issue open, i'm sure am going to get hammered with "you forgot this and that", so please just add to this about how i did it wrong rather than raising new issues!!!!!

@ceolter
Copy link
Contributor

ceolter commented Apr 13, 2015

no feedback . . . . . :( . . . . . might have to close the issue . . . . .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants