-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AG-6654 - Charts API Explorer Caching + Visual Improvements #5070
Conversation
@@ -28,6 +28,8 @@ export type AgChartThemeName = | |||
| 'ag-vivid' | |||
| 'ag-vivid-dark'; | |||
|
|||
export type MarkerShape = 'circle' | 'cross' | 'diamond' | 'heart' | 'plus' | 'triangle' | any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the any for the (new () => any) case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - my original motivation was that a JSONSchema generator I was trying to use was failing on the previous new () => void
- I don't think this is a significant degradation of the type information, given the generality of the previous definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
grid-packages/ag-grid-docs/documentation/doc-pages/charts-api/doc-interfaces.AUTO.json
Outdated
Show resolved
Hide resolved
Looks good! |
https://ag-grid.atlassian.net/browse/AG-6654
Primary changes:
JsonModel
- this change seeks to remove this calculation from the re-render path by introducing caching. (1011e65)theme
configurable interactively and adds JSDoc description for the field to improve self-documentation. (c81b4bd)Bonus:
Theme option beforehand:
![Screenshot 2022-04-07 at 12 17 45](https://user-images.githubusercontent.com/17544187/162187506-31172050-c10b-4f5c-8802-49ea110565fa.png)
Theme option after:
![Screenshot 2022-04-07 at 12 17 53](https://user-images.githubusercontent.com/17544187/162187551-0ec2d653-1a02-46f1-8ab5-763acb42bd88.png)