-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AG-6677 - Better null/undefined handling for scatter series charts. #5127
Merged
alantreadway
merged 4 commits into
latest
from
ag-6677/better-null-undefined-handling-scatter-series-charts
Apr 28, 2022
Merged
AG-6677 - Better null/undefined handling for scatter series charts. #5127
alantreadway
merged 4 commits into
latest
from
ag-6677/better-null-undefined-handling-scatter-series-charts
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manapeirov
reviewed
Apr 28, 2022
charts-packages/ag-charts-community/src/chart/series/cartesian/scatterSeries.ts
Outdated
Show resolved
Hide resolved
charts-packages/ag-charts-community/src/chart/series/cartesian/scatterSeries.ts
Outdated
Show resolved
Hide resolved
PTAL @manapeirov |
manapeirov
reviewed
Apr 28, 2022
charts-packages/ag-charts-community/src/chart/series/cartesian/scatterSeries.ts
Outdated
Show resolved
Hide resolved
manapeirov
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks Alan!
manapeirov
approved these changes
Apr 28, 2022
This was referenced May 13, 2022
alantreadway
deleted the
ag-6677/better-null-undefined-handling-scatter-series-charts
branch
October 10, 2022 11:10
This was referenced Jun 20, 2023
This was referenced Nov 28, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-6677
Completely removes scatter series datum from the plotted chart which are missing either an xKey or yKey value.