Made autoSizeColumns() to work with cells headers #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2016 16:57
…th based on the header as well as the cell. - Moved field definition from the ColDef interface to the AbstractColDef interface since we will need to access it. - Converted the headerElements, inside the headerContainer, to be an object so that we can find a specific element by id. This is exactly the same functionality that is used in the RendererRow class. - Added a getCellForCol function, inside the headerContainer, so that we can get the header html element for a specific column. - Added a getHeaderCelForColumn, inside the headerRnderer, to get a specific html element for a column. This is exactly the same functionality that is used in the rowRenderer class.
…l or not. If it is null, it will not generate the clone to avoid errors.
|
interesting. thanks. will take a look when i get a chance. |
|
+1 Yes Please :-) |
|
Any update on this? Seems like an obvious feature to have. |
|
Any update on this? Seems like an obvious feature to have. |
|
@ceolter when you are planning to release next version ? |
|
it didn't make release v5 :( i'm hoping to look at this tomorrow, before i go on my holidays the next day :( . . . . this is probably the feature i want most in the grid from all the small requested features. |
|
i have now implemented this. will be releasing later today. i didn't take the PR as a lot of code has changed (around how the headers work) since this PR was created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support, inside the autoWidthCalculator, to calculate the width based on the header as well as the cell.