Fix issue with rowClass not being considered when autoSizing a column. #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting. i'll have a think about this. thanks. |
|
i mean, i'm happy that there is a problem that should be fixed!!! i mean think about the solution. |
|
This issue has since been fixed so closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
rowClassis not being considered when auto-sizing on a column happens. This means that changes to font or emphasis done at the row-level do not end up being considered when sizing the column. This fixes that issue.Note: this does not copy
rowStyleproperties over to the cloned cell's parent, so there is still a gap there for those that use that feature.