Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming convention #25

Closed
gopar opened this issue Feb 15, 2023 · 1 comment · Fixed by #26
Closed

Naming convention #25

gopar opened this issue Feb 15, 2023 · 1 comment · Fixed by #26

Comments

@gopar
Copy link
Contributor

gopar commented Feb 15, 2023

Hey, thanks for the package. I see great potential for this! \o/

One thing I noticed is that everything is prefixed with c/ which is not common among package development.
prefix would ideally be code-compass- (bit verbose but that is the norm).

Are you open to updating?
I can make PR and still keep backwards compatibility (can be done with defalias)
@ag91
Copy link
Owner

ag91 commented Feb 15, 2023

yes, please: that is one of the steps required for #20 but I hadn't the time to handle it yet.
A PR would be greatly appreciated :)

@gopar gopar mentioned this issue Feb 15, 2023
Merged
@ag91 ag91 closed this as completed in #26 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update naming convention
2 participants
@gopar @ag91