Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow more customization for transfer speeds #1413

Merged
merged 3 commits into from
Apr 3, 2023
Merged

feat: Allow more customization for transfer speeds #1413

merged 3 commits into from
Apr 3, 2023

Conversation

SammCheese
Copy link
Contributor

@SammCheese SammCheese commented Apr 2, 2023

Description

This PR adds an Input field and a unit selector to transfer speeds.
This allows the user to Tweak speeds more to their likings.
Images Attached

image

Related Issues

Fixes #808
Fixes #1231
Fixes #860

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

@agalwood
Copy link
Owner

agalwood commented Apr 2, 2023

I think it is possible to maintain the original maxOverallDownloadLimit and maxOverallUploadLimit data structures. There is no need to introduce uploadUinit and downloadUnit in userKeys. You can get units (G, M, K) through parseInt and then replace, and computed to uploadUnit and downloadUnit.

@SammCheese
Copy link
Contributor Author

This should address your concerns regarding userKeys and the change of data structures.

@agalwood
Copy link
Owner

agalwood commented Apr 3, 2023

Nice job! Thanks for your contribution 👍

@agalwood agalwood merged commit 7201f17 into agalwood:master Apr 3, 2023
@shatyuka
Copy link
Contributor

shatyuka commented Apr 3, 2023

I got maxOverallDownloadLimit = number 0 here, means no limitation.

downloadUnits: {
get () {
const speedEnding = this.form.maxOverallDownloadLimit?.slice(-1)

speedOptions () {
return [
{
label: this.$t('preferences.transfer-speed-unlimited'),
value: 0
},

So it's not upgradable from older version.

@SammCheese
Copy link
Contributor Author

I have not considered that. I will try to fix that as soon as i can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants