Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock AddTask dialog #1416

Merged
merged 1 commit into from Apr 4, 2023
Merged

Conversation

shatyuka
Copy link
Contributor

@shatyuka shatyuka commented Apr 3, 2023

Description

Prevent from accidental close.

Related Issues

None

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

@agalwood
Copy link
Owner

agalwood commented Apr 4, 2023

Hi, Long time no see 😃

My idea is that when there is uri content in the addTask input box and the close button is clicked, would it be better to pop up a confirm for the user to choose? Because addTask will automatically read the resource link in the clipboard when it is opened, if I want to close the addTask dialog box, I need to delete the url content before closing it, which is a bit troublesome.

@shatyuka
Copy link
Contributor Author

shatyuka commented Apr 4, 2023

Sorry for the misleading. Only modal area will be locked.

@agalwood agalwood merged commit 06ffe6b into agalwood:master Apr 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants