Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Japanese language translation #225

Merged
merged 11 commits into from Apr 24, 2019
Merged

feat: Add Japanese language translation #225

merged 11 commits into from Apr 24, 2019

Conversation

hbkrkzk
Copy link
Contributor

@hbkrkzk hbkrkzk commented Apr 24, 2019

No description provided.

agalwood
agalwood requested changes Apr 24, 2019
View reviewed changes
Copy link
Owner

@agalwood agalwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, some places need you to modify it.

src/shared/locales/ja/index.js Outdated Show resolved Hide resolved
src/shared/locales/ja/preferences.js Show resolved Hide resolved
agalwood
agalwood requested changes Apr 24, 2019
View reviewed changes
Copy link
Owner

@agalwood agalwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to update the documentation, the translation configuration of the menu has been moved to locale. I will update the translation guide right away.
Just translate all the files in the locale directory.
https://github.com/agalwood/Motrix/tree/master/src/shared/locales/en-US

src/shared/locales/ja/preferences.js Show resolved Hide resolved
src/shared/locales/ja/preferences.js Outdated Show resolved Hide resolved
src/main/menus/ja/darwin.json Outdated Show resolved Hide resolved
@agalwood
Copy link
Owner

The translation guide has been updated : D
https://github.com/agalwood/Motrix/blob/master/CONTRIBUTING.md#-translation-guide

@hbkrkzk
Copy link
Contributor Author

hbkrkzk commented Apr 24, 2019

Thank you for your detail advice. I changed some places. Please check. Thanks!

@agalwood
Copy link
Owner

Please run dev on your computer and make sure your code passes eslint...

@agalwood
Copy link
Owner

Some simple formatting errors can be corrected using npm run lint:fix

@agalwood
Copy link
Owner

I will deal with the problem of eslint.

@agalwood agalwood changed the title Add Japanese language translation feat: Add Japanese language translation Apr 24, 2019
@agalwood agalwood merged commit e3afb14 into agalwood:master Apr 24, 2019
@lock
Copy link

lock bot commented May 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agalwood agalwood agalwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hbkrkzk @agalwood