Add pycharm, fix detached run, add utils functions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix run so it will be run detached - add get_dirs_in_dir, read_file and resport_issue to comeback.utils - get_dirs_in_dir - returns 1st level of dirs in a path - read_file - reads a file and closes the fd - report_issue - template for errors that need reporting - Fix the example dir structure
yammesicka
requested changes
Feb 25, 2019
|
|
||
| def run_plugin(cwd): | ||
| platform = utils.get_platform() | ||
| if platform == "windows": |
There was a problem hiding this comment.
Maybe we should Enum the platform?
There was a problem hiding this comment.
To use Platforms.WINDOWS or something instead of strings. (enum)
yammesicka
reviewed
Feb 25, 2019
yammesicka
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_pluginget_dirs_in_dir,read_fileandreport_issueto comeback.utilsget_dirs_in_dir- returns 1st level of dirs in a pathread_file- reads a file and closes the fdreport_issue- template for errors that need reportingAdds support for #4
fixes #9