Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PRs for clis on ideas.txt #267

Open
jneidel opened this issue Mar 6, 2019 · 14 comments
Open

Create PRs for clis on ideas.txt #267

jneidel opened this issue Mar 6, 2019 · 14 comments
Labels

Comments

@jneidel
Copy link
Collaborator

jneidel commented Mar 6, 2019

Create a PR for every entry in ideas.txt.

This will make it easier to review the entries. Right now it's hard to discuss whenever or not one of them is worth merging.

After creating the clis as PRs remove them from the ideas.txt.

@sjclayton
Copy link
Collaborator

sjclayton commented Mar 7, 2019

Would prefer PR's for this as well... Issues should be limited to things such as new category / subcategory suggestions, move requests (ie. changing the category of a particular CLI app), description updates, enhancements and other similar requests.

EDIT: I am considering adding an issue template with a message kindly asking people to refrain from submitting additions to the list as issues.

@jneidel jneidel changed the title Create issues/PRs for clis on ideas.txt Create PRs for clis on ideas.txt Mar 7, 2019
@capaldo
Copy link
Collaborator

capaldo commented May 7, 2019

How would you want to go about this? I can start adding the PR's little by little then remove them from the ideas.txt if you guys are open to it.

@jneidel
Copy link
Collaborator Author

jneidel commented May 8, 2019

I can start adding the PR's little by little then remove them from the ideas.txt if you guys are open to it.

@capaldo That would be perfect 😄👍

@jneidel
Copy link
Collaborator Author

jneidel commented May 10, 2019

I've sorted and vetted the list, which should make it easier to create PRs from them.

@capaldo
Copy link
Collaborator

capaldo commented May 10, 2019

Since this is an ongoing effort and has been greatly improved can we close this or would you guys want to keep this open @jneidel @sjclayton

@jneidel
Copy link
Collaborator Author

jneidel commented May 10, 2019

@capaldo I think we can close this once the list is gone. This way we know that it's still an issue.

jneidel added a commit that referenced this issue Jul 5, 2019
@jneidel
Copy link
Collaborator Author

jneidel commented Jul 20, 2019

Can we remove dark-mode? This can be accomplished with an alias to an AppleScript.

@capaldo there are a lot of utils already on the list that replicated as a simple bash scripts (adapted to my setup).
If we apply the 'can be done using a simple script' argument we'd have to vet the existing list as well.

And some people can't, or don't want to write those scripts themselves...

@capaldo
Copy link
Collaborator

capaldo commented Jul 20, 2019

Can we remove dark-mode? This can be accomplished with an alias to an AppleScript.

@capaldo there are a lot of utils already on the list that replicated as a simple bash scripts (adapted to my setup).
If we apply the 'can be done using a simple script' argument we'd have to vet the existing list as well.

And some people can't, or don't want to write those scripts themselves...

Ok thats understandable.

@jneidel
Copy link
Collaborator Author

jneidel commented Jul 20, 2019

But maybe we can group them together in a specific category. Most of the ones I referenced above (battery-level, brightness, yank, screensaver) I moved to a new category in #344.

@capaldo
Copy link
Collaborator

capaldo commented Jul 20, 2019

But maybe we can group them together in a specific category. Most of the ones I referenced above (battery-level, brightness, yank, screensaver) I moved to a new category in #344.

I was thinking dark mode to go under macOS since its unique to that.

@jneidel
Copy link
Collaborator Author

jneidel commented Jul 21, 2019

I was thinking dark mode to go under macOS since its unique to that.

That's were I would put it as well, I just wanted to reference what I wanted to do with similar apps.

@capaldo capaldo mentioned this issue Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants