Skip to content
This repository has been archived by the owner on Mar 16, 2018. It is now read-only.

result div not correct width when input has padding. #25

Open
mcornman opened this issue Nov 2, 2011 · 6 comments
Open

result div not correct width when input has padding. #25

mcornman opened this issue Nov 2, 2011 · 6 comments

Comments

@mcornman
Copy link

mcornman commented Nov 2, 2011

Hi,

So I am new to github and the autocomplete plugin but I like it so much more than the one built into JQueryUI.

Amway, I found one thing that I wanted to submit as a UI adjustment: if input text element has left/right padding, result DIV does not come back at the correct width.

Line 765:

width: typeof options.width == "string" || options.width > 0 ? options.width : $(input).width(),

could be replaced with:

width: typeof options.width == "string" || options.width > 0 ? options.width : $(input).width() + parseInt($(input).css("padding-left")) + parseInt($(input).css("padding-right")), 

I also have a nice demo page to add to this plugin showing above that includes some formatting. not sure how to attach but I could email.

thanks!

@agarzola
Copy link
Owner

agarzola commented Nov 4, 2011

Hey, mcornman!

I appreciate the effort and your interest in helping to keep this project up to date! This would certainly be a useful update. You’re more than welcome to send me any relevant files to my email: alfonso [at] agarzola [dot] com.

Thanks again!

@mcornman
Copy link
Author

sent a couple of weeks ago... did you get?

@agarzola
Copy link
Owner

Hey, Martin!

Sorry I haven’t responded with this. I’ve been swamped with work and personal obligations. I haven’t lost track of this, though. I appreciate the reminder.

Thanks!


Alfonso Gómez-Arzola

On Tuesday, November 22, 2011 at 2:21 PM, martin wrote:

sent a couple of weeks ago... did you get?


Reply to this email directly or view it on GitHub:
#25 (comment)

@mcornman
Copy link
Author

OK no worries, just wanted to make sure it didn't hit the junk mail folder :)

@agarzola
Copy link
Owner

Not at all, Martin.

Have a nice day!


Alfonso Gómez-Arzola

On Tuesday, November 22, 2011 at 2:28 PM, martin wrote:

OK no worries, just wanted to make sure it didn't hit the junk mail folder :)


Reply to this email directly or view it on GitHub:
#25 (comment)

@mihdan
Copy link

mihdan commented Mar 13, 2012

width: typeof options.width == "string" || options.width > 0 
    ? options.width 
    : $(input).outerWidth(),

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants