change: Add support for more ncurses functions #5
Conversation
Allows you to `NCurses.curs_set(0)` to hide the cursor
Handles resizing windows
Allows you to create ncurses subwindows
geolessel
force-pushed
the
more-ncurses
branch
from
439bb16
to
fb14fd6
Compare
src/ncurses/window.cr
Outdated
| @@ -23,6 +24,26 @@ module NCurses | |||
| end | |||
| end | |||
|
|
|||
| def self.subwin(height, width, y, x, parent, &blk) | |||
| win = new(LibNCurses.subwin(parent, height, width, y, x)) | |||
| wind.closed = false | |||
There was a problem hiding this comment.
win.closed = false ?
@closed is false by default, so I guess this line is not necessary.
There was a problem hiding this comment.
@agatan yes, I don't believe it is necessary.
src/ncurses/window.cr
Outdated
| @@ -3,6 +3,7 @@ require "./raw_window" | |||
|
|
|||
| module NCurses | |||
| class Window | |||
| property closed : Bool = false | |||
There was a problem hiding this comment.
What is the purpose of this line?
I think that closed is a private (internal) property or read-only property.
If closed property is assigned true by external code by mistake, the window resource will never be closed.
Would you give us any examples to use closed property?
I agree to add closed? method to read @closed state!
There was a problem hiding this comment.
@agatan It appears I never actually used that closed property anyway, so I'll remove this addition.
|
@agatan I've updated the PR based on your comments. |
Thanks for the project! I've been using it for a side project while I'm learning Crystal and have found it pretty easy to use. However, there were some ncurses functions that I wanted to have supported and added them here. Do these look OK?
I am learning Crystal and ncurses at the same time, so feel free to point me in a better direction if needed.