Fix model multiple choice preference to react correctly to deletion handler #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agateblue Is there any progress on this topic? It would be nice to get at least some feedback because this a very critical bug in our school information system AlekSIS. |
|
Hi @hansegucker. Apologies for the delay and thank you for the contribution. Let's merge and I'll try to make a release next week. Take care |
Thanks for merging, @agateblue! Is there any progress with releasing a new version? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you delete an object whose model is also used for a model multiple choice preference, it will cause some trouble because the preference uses
create_deletion_handlerto create a handler for the delete signal of this model. For a normal model choice field that works perfectly, but not for a model multiple choice field: The serializer only supports querysets and not single objects as provided through the signal handler.