Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $validator arg in AgaviValidationIncident::__construct() optional #1526

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasbachem
Copy link
Contributor

No description provided.

@ddelbondio
Copy link
Member

could you please provide a use case for this? (i know we discussed this, but i can't remember what it was)

@ddelbondio ddelbondio added this to the 1.1.0 milestone Mar 5, 2015
@thomasbachem
Copy link
Contributor Author

It had something to do with manually triggering validation errors, e.g. with

$incident = new AgaviValidationIncident(null);
$incident->addError(new AgaviValidationError($message, $index, $affectedArguments));

$report = $this->getContainer()->getValidationManager()->getReport();
foreach($affectedArguments as $argument) {
    $report->addArgumentResult($argument, $severity);
}
$report->addIncident($incident);

But it's mostly a cosmetic improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants