Hotfix/remove patch #206
Merged
Hotfix/remove patch #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldemarnt
force-pushed
the
hotfix/remove-patch
branch
from
153a5f5
to
b4d257e
Compare
Juraci
approved these changes
Mar 28, 2017
lucaslago
reviewed
Mar 28, 2017
| @@ -13,30 +13,36 @@ describe("includes", function () { | |||
| function setupLinks(_ids) { | |||
| ids = _ids; | |||
|
|
|||
| function link(url, path, value) { | |||
| function link(resource, resourceId, link, linkId) { | |||
| const url = `/${resource}/${resourceId}`; | |||
There was a problem hiding this comment.
Could you explain this change? It seems you followed a TODO comment that led you to this change.
There was a problem hiding this comment.
I had to rewrite tests on which PATCH were used to use PUT instead
| op: 'replace', | ||
| path: path, | ||
| value: value | ||
| var data = { |
There was a problem hiding this comment.
data is an object now, is this intentional? What's the reason behind this contract change?
There was a problem hiding this comment.
Didn't change the test behaviour, it's passing, I just changed it to be an object as the PUT method expects.
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the PATCH support due the issue #203 .
Coverage decreased (-1.5%) to 82.699% when pulling b4d257e on hotfix/remove-patch into 6bd13df on develop.
Coverage decreased (-1.5%) to 82.699% when pulling b4d257e on hotfix/remove-patch into 6bd13df on develop.
This change is