Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README typos and clarifications #524

Closed
desenna opened this issue Jan 13, 2018 · 2 comments
Closed

README typos and clarifications #524

desenna opened this issue Jan 13, 2018 · 2 comments
Assignees

Comments

@desenna
Copy link

desenna commented Jan 13, 2018

Hello,

I just got through my first cookiecutter experience and have a few small items to share:

  1. 'sever' should be 'server' (e.g. 'Initializing the production sever:')
  2. In the sample code for section 'Initializing the qa sever:', in order to get my heroku qa environment set up properly, I needed to add 3 '--app {{cookiecutter.app_name}}-prod'... not sure if I'm the only one who faced this issue or not
  3. The first go-round I had in getting this thing setup, I started with a repo and app name that began with a number instead of a letter... this caused problems w.r.t. heroku naming policies and also with getting my tests to pass (I kept getting Django 'missing app label' errors or that I hadn't included it in INSTALLED_APPS). I had a heckuva time trying to figure this out before renaming, which solved the issue. Might be worth a mention to save time for other newbies like me, unless this is a well-understood convention.
@desenna
Copy link
Author

desenna commented Jan 13, 2018

BTW, if these are valid issues, happy to submit some PRs if you'd like... if so, please let me know if you'd like this as 3 separate or if one will do. Thanks

@desenna desenna changed the title README typos README typos and clarifications Jan 13, 2018
@agconti agconti self-assigned this Jan 20, 2018
@agconti
Copy link
Owner

agconti commented Jan 24, 2018

Hey @desenna, thanks for opening this issue up! 💖

These issues were resolved via #520

@agconti agconti closed this as completed Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants