-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observation: .agdai files recently became much bigger #1928
Comments
I guess we should understand why this happens before releasing it. |
I've put two new things in interfaces recently: The former could reasonably easily be recomputed on reading an interface. The latter, not so much. If it's the display forms that are the problem it might be that I'm storing more of them that are strictly necessary. |
On Fri, Apr 08, 2016 at 01:52:01AM -0700, Ulf Norell wrote:
Are those before dead-code elimination? If yes, that would partially undo the good effects of dead-code elimination... |
If those sets really are only the names in scope, then they would not include dead code, but of course it might be that the interfaces contain more scope data than it should really need. Did you check that it is the name sets that are the culprits? |
On Fri, Apr 08, 2016 at 05:57:16AM -0700, Ulf Norell wrote:
How do I inspect .agdai files? |
That is a long standing issue, that we cannot easily see what really ends up in the agdai files. However, you can run your tests with the additional |
On Fri, Apr 08, 2016 at 07:05:05AM -0700, Andreas Abel wrote:
Try to have somebody hack on that at AIM! 😉
I'll try. Wolfram |
Oh.. I was thinking you would just try the two commits I gave above to see where the problem was introduced. The display forms were added after the scope stuff. |
With Agda-2.4.3.34:
|
Ah, sorry, this option only collects the additional information, but does not output it. Haha! |
You should get something like
|
FWIW, you can use |
Does |
Only the last .agdai file. |
Now I ran
2016-04-08-AContext2-Agda-2.4.3.32_profile.serialize.log.txt |
That change made .agdai files only a little bit larger, but seems to have had a beneficial effect on run time: Added a
|
I did some pruning of exported display forms that should fix the problem. On the standard library the interface files went from 5% bigger than before 24ed64c to 0.2% bigger. |
For my example, the effect has disappeared, too: Summary with new last line for 7ba987b:
Thank you! |
With very recent development versions, I see significantly larger
.agdai
files. I'd guess this is connected with some of the changes around #1923.-v profile:7
information is attached:large_agdai_2016-04-07_AContext2_log.txt
Agda-2.4.3.34 is d14b90b pulled 2016-04-07, compiled with ghc-7.10.3; with standard library pulled as sub-module: 196dcce
Agda-2.4.3.34a is bcfcd19 pulled 2016-04-06, compiled with ghc-7.10.3; with standard library pulled as sub-module: 196dcce
Agda-2.4.3.32 is 33f5bbf pulled 2016-03-31, compiled with ghc-7.10.3; with standard library pulled as sub-module: 196dcce
Agda-2.4.3.26 is e2d0a78 pulled 2016-03-03, compiled with ghc-7.10.3; with standard library pulled as sub-module: dcc2ab7
The text was updated successfully, but these errors were encountered: