Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ warnings ] for empty primitive blocks #3485

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Conversation

gallais
Copy link
Member

@gallais gallais commented Jan 2, 2019

Rather than brutally failing with a parse error, we accept empty
primitive blocks and warn the user about them later on in the
nicifier.

Rather than brutally failing with a parse error, we accept empty
primitive blocks and warn the user about them later on in the
nicifier.
@gallais gallais added type: enhancement Issues and pull requests about possible improvements ux: warnings Issues relating to the reporting of warnings labels Jan 2, 2019
@gallais gallais added this to the 2.6.1 milestone Jan 2, 2019
@gallais gallais mentioned this pull request Feb 7, 2019
@gallais gallais modified the milestones: 2.6.1, 2.6.0 Feb 7, 2019
@gallais gallais merged commit 6cc14f0 into master Feb 7, 2019
@gallais gallais deleted the empty-primitive-block branch February 7, 2019 13:08
jespercockx pushed a commit to jespercockx/agda that referenced this pull request Feb 26, 2019
Rather than brutally failing with a parse error, we accept empty
primitive blocks and warn the user about them later on in the
nicifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Issues and pull requests about possible improvements ux: warnings Issues relating to the reporting of warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant