Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tactic command runs forever #5283

Closed
guilhermehas opened this issue Mar 21, 2021 · 2 comments · Fixed by #5523
Closed

Tactic command runs forever #5283

guilhermehas opened this issue Mar 21, 2021 · 2 comments · Fixed by #5523
Assignees
@andreasabel
Labels
reflection Elaborator reflection, macros, tactic arguments regression in 2.6.1 Regression that first appeared in Agda 2.6.1 tactic tactic annotations
Milestone
2.6.2.1

Comments

@guilhermehas
Copy link

When I try to compile this program, it never finishes:

data ⊥ : Set where

_ : ⊥
_ = tactic ?
@andreasabel
Copy link
Member

andreasabel commented Aug 19, 2021 •
edited
Loading

MWE:

open import Agda.Builtin.Reflection

A : Set
A = tactic ?

This fails in 2.6.0 with unsolved constraints, starting with 2.6.1 it loops.

@andreasabel andreasabel added reflection Elaborator reflection, macros, tactic arguments regression in 2.6.1 Regression that first appeared in Agda 2.6.1 labels Aug 19, 2021
@andreasabel
Copy link
Member

Turns out that the scope checker accepts tactic ? as expression, but the type checker never handles it. (It is ping-ponged forever between checkExpr and checkApplication, I suppose.)

@andreasabel andreasabel self-assigned this Aug 19, 2021
@andreasabel andreasabel added this to the 2.6.2.1 milestone Aug 19, 2021
andreasabel added a commit that referenced this issue Aug 19, 2021
@andreasabel
[ fix #5283 ] by refuting expression "tactic e" in scope checker
687f3ef 
'tactic' can only appear in attributes, it has been added to
Abstract.Syntax on error.
andreasabel added a commit that referenced this issue Aug 19, 2021
@andreasabel
[ #5283 ] purge Tactic from abstract syntax
924343f 
This is an unused constructor that only causes confusion.
@andreasabel andreasabel mentioned this issue Aug 19, 2021
Merged
@andreasabel andreasabel added the tactic tactic annotations label Aug 19, 2021
andreasabel added a commit that referenced this issue Aug 19, 2021
@andreasabel
[ fix #5283 ] by refuting expression "tactic e" in scope checker
3181c0a 
'tactic' can only appear in attributes, it has been added to
Abstract.Syntax on error.
andreasabel added a commit that referenced this issue Aug 19, 2021
@andreasabel
[ #5283 ] purge Tactic from abstract syntax
6c56133 
This is an unused constructor that only causes confusion.
andreasabel added a commit that referenced this issue Nov 17, 2021
@andreasabel
[ fix #5283 ] by refuting expression "tactic e" in scope checker
e87e3d5 
'tactic' can only appear in attributes, it has been added to
Abstract.Syntax on error.
andreasabel added a commit that referenced this issue Nov 17, 2021
@andreasabel
[ #5283 ] purge Tactic from abstract syntax
09a69c1 
This is an unused constructor that only causes confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
reflection Elaborator reflection, macros, tactic arguments regression in 2.6.1 Regression that first appeared in Agda 2.6.1 tactic tactic annotations
Projects
None yet
Milestone
2.6.2.1
Development

Successfully merging a pull request may close this issue.

Fix #5283: reject 'tactic' expressions in scope checker agda/agda
2 participants
@andreasabel @guilhermehas