Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The JS backend "installs" highlight-hover.js #5433

Closed
nad opened this issue Jun 3, 2021 · 3 comments · Fixed by #5474
Closed

The JS backend "installs" highlight-hover.js #5433

nad opened this issue Jun 3, 2021 · 3 comments · Fixed by #5474
Assignees
Labels
backend: html HTML generation backend backend: js JavaScript generation backend type: bug Issues and pull requests about actual bugs
Milestone

Comments

@nad
Copy link
Contributor

nad commented Jun 3, 2021

When you compile using the JS backend the file highlight-hover.js is copied into the output directory. @ice1000, is this file used by the JS backend? I guess the answer is no. This can presumably be fixed by moving this file to its parent directory and removing "JS" </> from the following code:

highlightJsFile <- getDataFileName $
"JS" </> occurrenceHighlightJsFile

@nad nad added type: bug Issues and pull requests about actual bugs backend: js JavaScript generation backend labels Jun 3, 2021
@nad nad added this to the 2.6.3 milestone Jun 3, 2021
@ice1000
Copy link
Member

ice1000 commented Jun 3, 2021

I guess the answer is no.

You are right

@ice1000
Copy link
Member

ice1000 commented Jun 3, 2021

So the JS directory is for the JS backend only. I guess it's a good idea to document this behavior.

@nad
Copy link
Contributor Author

nad commented Jun 4, 2021

So the JS directory is for the JS backend only.

Well, the JS backend copies everything from that directory into the target directory:

compDir <- compileDir
liftIO $ do
dataDir <- getDataDir
let srcDir = dataDir </> "JS"
copyDirContent srcDir compDir

I guess it's a good idea to document this behavior.

Perhaps a file with documentation could be put in the parent directory.

@andreasabel andreasabel self-assigned this Jul 14, 2021
@andreasabel andreasabel added the backend: html HTML generation backend label Jul 14, 2021
andreasabel added a commit that referenced this issue Jul 14, 2021
Added a README explaining the organization and moved the files of the
LaTeX backend to their own subdirectory.
andreasabel added a commit that referenced this issue Jul 14, 2021
Added a README explaining the organization and moved the files of the
LaTeX backend to their own subdirectory.
@andreasabel andreasabel modified the milestones: 2.6.3, 2.6.2.1 Aug 18, 2021
andreasabel added a commit that referenced this issue Nov 17, 2021
Added a README explaining the organization and moved the files of the
LaTeX backend to their own subdirectory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: html HTML generation backend backend: js JavaScript generation backend type: bug Issues and pull requests about actual bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants