Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint solving does not honour singleton types #6073

Closed
plt-amy opened this issue Sep 1, 2022 · 5 comments · Fixed by #6171
Closed

Constraint solving does not honour singleton types #6073

plt-amy opened this issue Sep 1, 2022 · 5 comments · Fixed by #6171
Assignees
Labels
cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp singleton-types Issues related to conversion modulo eta-equality for singleton types type: bug Issues and pull requests about actual bugs
Milestone

Comments

@plt-amy
Copy link
Member

plt-amy commented Sep 1, 2022

Making a separate bug so I can keep #6071 a discussion. Here's issue #593, now with the latest trendy thing:

“unit” : _
“unit” = Sub Nat i1 λ ._  42

“tt” : “unit”
“tt” = inS 42

data _≡ₛ_ {A : SSet} (a : A) : A  SSet where
  reflₛ : a ≡ₛ a

-- demonstrating definitional eta:
_ :  {x y : “unit”}  x ≡ₛ y
_ = reflₛ

refl :  {l} {A : Set l} {x : A}  PathP (λ i  A) x x
refl {x = x} i = x

bla7 : (F : “unit”  Set) ->
  let X : Set
      X = _
  in (z : “unit”) -> PathP (λ i  Set) X (F z)
bla7 F z = refl

Easy fix: isSingletonType' should return Just (x 1=1) when given Sub A i1 x, blocking on the φ argument.

@plt-amy plt-amy added type: bug Issues and pull requests about actual bugs cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp singleton-types Issues related to conversion modulo eta-equality for singleton types labels Sep 1, 2022
@plt-amy
Copy link
Member Author

plt-amy commented Sep 1, 2022

Totally off-topic but it's very humbling to revisit an old issue and see that it's just a tad over half my age.

@jespercockx
Copy link
Member

Possibly related: #5837

@jespercockx jespercockx added this to the 2.6.3 milestone Sep 13, 2022
@jespercockx
Copy link
Member

@plt-amy I've assigned you and added the 2.6.3 milestone, but feel free to bump it to another one if you don't have the time now.

@plt-amy
Copy link
Member Author

plt-amy commented Sep 13, 2022

@jespercockx sounds good; I'm fairly sure the solution I sketched works, but I haven't pushed it yet since I'm banned from Actions, so CI doesn't run on my PRs 😔

I've reached out to support but haven't heard anything back, yet.

@jespercockx
Copy link
Member

If you can push your branch to here then I can create the PR for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp singleton-types Issues related to conversion modulo eta-equality for singleton types type: bug Issues and pull requests about actual bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants