New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some options should be listed in restartOptions
#6265
Comments
The difference between the new functionality and the old one is that the old functionality does not trigger a recheck when one of the following options changes, but the new one does: * optCopatterns * optFirstOrder * optFlatSplit * optForcing * optKeepCoveringClauses * optPatternMatching * optProjectionLike Furthermore the new functionality is safer in the sense that, if one forgets to update the functionality when a new option is added, then one risks getting too many rechecks rather than too few.
If the changes in my pull request are included changes to these options should trigger a recheck.
I did not change the treatment of these options (except that I removed an occurrence of I also noted that a change to
I made the functionality safer in the sense that, if one forgets to update the functionality when a new option is added, then one risks getting too many rechecks rather than too few. |
The difference between the new functionality and the old one is that the old functionality does not trigger a recheck when one of the following options changes, but the new one does: * optCopatterns * optFirstOrder * optFlatSplit * optForcing * optKeepCoveringClauses * optPatternMatching * optProjectionLike Furthermore the new functionality is safer in the sense that, if one forgets to update the functionality when a new option is added, then one risks getting too many rechecks rather than too few.
Yes, this seems the safer way round. |
The difference between the new functionality and the old one is that the old functionality does not trigger a recheck when one of the following options changes, but the new one does: * optCopatterns * optFirstOrder * optFlatSplit * optForcing * optKeepCoveringClauses * optPatternMatching * optProjectionLike Furthermore the new functionality is safer in the sense that, if one forgets to update the functionality when a new option is added, then one risks getting too many rechecks rather than too few.
The following options are not listed in
restartOptions
:optCopatterns
optFirstOrder
optFlatSplit
optForcing
optKeepCoveringClauses
optPatternMatching
optProjectionLike
The following options related to backends are also not included, but perhaps that is fine, if the idea is that the backends should take care of recompilation logic:
optCompileNoMain
optCountClusters
Perhaps the following options related to performance could be removed from the list:
optCallByName
optFastReduce
optSaveMetas
It is apparently easy to forget to add a new option to
restartOptions
. Perhaps we could instead use a function that blanks out options that should not trigger a "restart".The text was updated successfully, but these errors were encountered: