Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcomp symbols in interface not hidden under --cubical-compatible #7048

Closed
sattlerc opened this issue Jan 5, 2024 · 1 comment · Fixed by #7049
Closed

hcomp symbols in interface not hidden under --cubical-compatible #7048

sattlerc opened this issue Jan 5, 2024 · 1 comment · Fixed by #7049
Assignees
Labels
cubical-compatible Concerning e.g. extra clauses generated for cubical interface Serialization and loading of interface files type: bug Issues and pull requests about actual bugs
Milestone

Comments

@sattlerc
Copy link
Contributor

sattlerc commented Jan 5, 2024

From #7044 (comment):

When printing the signatures of the interface, I see Inner.hcomp-T. Why is that generated without --cubical-compatible?

Test case:

module Inner where

data T : Set where
  t : T

Running

agda-quicker Inner.agda -v 5 | grep hcomp

shows that cubical-related code is executed:

Generated name: [...] "hcomp-T" [...]
@sattlerc sattlerc added bug or feature? It may be a bug, it may be a feature. cubical-compatible Concerning e.g. extra clauses generated for cubical labels Jan 5, 2024
@sattlerc sattlerc changed the title hcomp symbols not hidden under --cubical-compatible hcomp symbols in interface not hidden under --cubical-compatible Jan 5, 2024
@andreasabel
Copy link
Member

I suppose a check for --cubical-compatible is missing here:

comp <- if nofIxs /= 0 || (Info.defAbstract i == AbstractDef)
then return emptyCompKit
else inTopContext $ defineCompData d con params names fields dataT boundary

and here:
-- we define composition here so that the projections are already in the signature.
escapeContext impossible npars $ do
addCompositionForRecord name haveEta con tel (map argFromDom fs) ftel rect

@andreasabel andreasabel self-assigned this Jan 5, 2024
@andreasabel andreasabel added this to the 2.6.4.2 milestone Jan 5, 2024
@andreasabel andreasabel added the interface Serialization and loading of interface files label Jan 5, 2024
@sattlerc sattlerc added type: bug Issues and pull requests about actual bugs and removed bug or feature? It may be a bug, it may be a feature. labels Jan 5, 2024
@andreasabel andreasabel modified the milestones: 2.6.5, 2.6.4.2 Feb 7, 2024
@andreasabel andreasabel mentioned this issue Feb 8, 2024
3 tasks
VitalyAnkh pushed a commit to VitalyAnkh/agda that referenced this issue Mar 5, 2024
JobPetrovcic pushed a commit to JobPetrovcic/agda that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubical-compatible Concerning e.g. extra clauses generated for cubical interface Serialization and loading of interface files type: bug Issues and pull requests about actual bugs
Projects
None yet
2 participants