TBT: Bug in size preservation regarding local definitions

[andreasabel]

TBT accepts a non-productive definition, which we can exploit to make the Agda loop:

{-# OPTIONS --type-based-termination #-}
{-# OPTIONS --size-preservation #-} -- default

-- {-# OPTIONS -v term.tbt:50 #-}

record U : Set where
  coinductive
  field force : U
open U

-- This is not size-preserving, but classified as such:
id : U → U
id u = u' .force where u' = u

-- This should not be accepted:
u : U
u .force = id u

open import Agda.Builtin.Equality

-- Type checker loops:
diverge : u .force ≡ u .force
diverge = refl

ATTN: @knisht

[andreasabel]

This exploit also works for inductive types:

open import Agda.Builtin.Nat

f : Nat → Nat
f x = x' where x' = suc (suc x)

diverge : Nat → Nat
diverge zero = zero
diverge (suc n) = diverge (f n)

Accepted by TBT.

[andreasabel]

And BOOM!

I did finally manage to show the current size-preservation analysis inconsistent:

{-# OPTIONS --type-based-termination #-}

data ⊥ : Set where

record _×_ (A B : Set) : Set where
  field
    fst : A
    snd : B
open _×_

record U : Set where
  coinductive; constructor delay
  field force : U × ⊥
open U

f : U → U × ⊥
f u = u' .force where u' = u

u : U
u .force = f u

absurd : ⊥
absurd = u .force .snd

TBT accepts f as size-preserving yet it is not.

[andreasabel]

The use of with is (expectedly) also affected, you can swap f for this implementation:

f : U → U × ⊥
f u with u
... | u' = u' .force

[knisht]

Postmortem:
I had an optimisation where I did not record constraints of the form i ≤ ∞. Seems reasonable, but if i is a contravariant size variable, then the constraint should be reversed, and it starts making sense.