Fix build with GHC 8.0.2 #2310
Merged
Fix build with GHC 8.0.2 #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
commented
Nov 22, 2016
| @@ -1,4 +1,6 @@ | |||
| {-# LANGUAGE CPP #-} | |||
| {-# LANGUAGE GADTs #-} | |||
| {-# LANGUAGE NoMonoLocalBinds #-} | |||
There was a problem hiding this comment.
So you might be wondering why enabling NoMonoLocalBinds is necessary here. The confusing reality is that enabling GADTs implies also enabling MonoLocalBinds, which causes dozens of functions below to have monomorphic inferred type signatures (even in the presence of NoMonomorphismRestriction!) Thus we need to have NoMonoLocalBinds appear after GADTs to counter this behavior.
|
We should get 2.5.1.2 (which would just be 2.5.1.1 + this commit) out asap. I filed #2311. |
|
Yes, also because of |
|
Yeah, the alex issue alone causes CI to fail on all nodes: https://bot.brew.sh/job/Homebrew%20Testing/1168/ |
UlfNorell
referenced
this pull request
Nov 23, 2016
ghc-8.0.2-rc1 compiles the modules in a different order from previous versions of ghc leading to the test failing. Since we only care that the compilation was successful we can ignore the ghc output completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agda has symptoms of code that was pointed out in GHC Trac #12784, and as a result, Agda fails to build with GHC 8.0.2. This PR fixes the situation by reworking some default type signatures so that they are more correct w.r.t. their type variables.