Add missing test case #3348
Merged
Add missing test case #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
UlfNorell
approved these changes
Nov 1, 2018
|
You now have the power to merge at your own discretion. |
I know, I just want others to get my code reviewed. |
Yes, submitting a PR is still good practice. I just meant that you should feel free to merge it yourself once people had had a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ice1000 ice1000kotlin@foxmail.com
Add a test case which was originally added in #3313 but possibly deleted by @vlopezj by accident when rebasing my changes.