Fix concurrency bug in test suite #6850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
reviewed
Sep 14, 2023
andreasabel
approved these changes
Sep 14, 2023
andreasabel
added
the
infra: test suite
andreasabel
reviewed
Sep 14, 2023
Co-authored-by: Andreas Abel <andreas.abel@ifi.lmu.de>
andreasabel
reviewed
Oct 7, 2023
| -- hPutStrLn stderr $ unwords $ agdaBin : envArgs ++ args | ||
| let agdaProc = (proc agdaBin (envArgs ++ args)) { create_group = True } | ||
| let agdaProc = (proc (getAgdaBin env) (envArgs ++ args)) { create_group = True , env = Just env } |
There was a problem hiding this comment.
@lawcho: Could this change somehow have triggered
There was a problem hiding this comment.
So this is likely a bug in the process library that only surfaces on macOS. The fix of this bug suggests that setting cwd here would workaround this bug, see https://github.com/haskell/process/pull/296/files.
There was a problem hiding this comment.
My experiments confirm that indeed this PR surfaced the bug in process currently affecting GHCs 9.2.8, 9.4.7, and 9.6.3. Sorry, you stepped on a mine here, you take no blame.
JobPetrovcic
pushed a commit
to JobPetrovcic/agda
that referenced
this pull request
Apr 12, 2024
Instead of manipulating the system environment, just pass an updated environment when you run the agda process. This way, environment settings from one test case cannot leak into another one in concurrent execution. Commits: * Set subprocess env declaratively * Add back env-var expansion * Use reverse instead of foldl' * Calculate agda env-args without IO * Add type synonym * Purify getAgdaBin * Fix confusion of extra/combined env * Refactor fold * Document .flags and .vars testing infrastructure * Fix whitespace * Update comment * Cosmetic fixes in `.vars` description * Apply suggestions from code review Co-authored-by: Andreas Abel <andreas.abel@ifi.lmu.de> --------- Co-authored-by: Andreas Abel <andreas.abel@ifi.lmu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6832