Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutual information not being set properly by the positivity checker #7149

Merged
merged 1 commit into from Feb 26, 2024

Conversation

UlfNorell
Copy link
Member

@UlfNorell UlfNorell commented Feb 26, 2024

Fixes #7133

Note to future git-bisecters

The missing mutual information caused some functions to not be considered for projection-likeness, so if you end up blaming this commit, there might be a bug with projection-likeness.

@UlfNorell UlfNorell added this to the 2.7.0 milestone Feb 26, 2024
@UlfNorell UlfNorell self-assigned this Feb 26, 2024
@UlfNorell UlfNorell merged commit 2928343 into master Feb 26, 2024
25 checks passed
@UlfNorell UlfNorell deleted the issue7133 branch February 26, 2024 11:36
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Should we maybe keep the TODO note here? Seems still valid after the fix.

src/full/Agda/TypeChecking/Positivity.hs Show resolved Hide resolved
VitalyAnkh pushed a commit to VitalyAnkh/agda that referenced this pull request Mar 5, 2024
…er (agda#7149)

fix agda#7133: mutual information not being set properly by the positivity
checker

_Note to future git-bisecters_

The missing mutual information caused some functions to not be considered for projection-likeness, so if you end up blaming this commit, there might be a bug with projection-likeness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimer internal error when querying recRecursive
2 participants