Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile sections #21

Merged
merged 4 commits into from Nov 4, 2020
Merged

Compile sections #21

merged 4 commits into from Nov 4, 2020

Conversation

UlfNorell
Copy link
Member

@UlfNorell UlfNorell commented Nov 3, 2020

On top of #20

@UlfNorell UlfNorell marked this pull request as draft November 3, 2020 14:01
Main.hs Outdated
@@ -329,13 +329,9 @@ compileType t = do
t -> genericDocError =<< text "Bad Haskell type:" <?> prettyTCM t

compileTerm :: Term -> TCM (Hs.Exp ())
compileTerm v =
compileTerm v = do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This do is unnecessary, probably a leftover from debugging?

Main.hs Show resolved Hide resolved
Copy link
Contributor

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omelkonian omelkonian merged commit 45b8f10 into master Nov 4, 2020
@UlfNorell UlfNorell deleted the sections branch November 4, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants