-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files should not import Everything files unless necessary #570
Comments
This should also be added to the styleguide |
Maybe off-topic, but I wonder why Cubical.Foundations.Everything renames a number of functions which are not reexported at all. What is the intended purpose of |
Currently, when I checkout the master branch and try to type-check Cubical.README, it fails because Cubical.Functions.Everything is missing. I see that there is a script Everythings.hs for generating them, but there is no guide about what I'm supposed to do at this point. |
You can run make. I think this was mentioned as an installation step in the past, but got removed. So this is only mentioned in CONTRIBUTING.md now. I guess the idea is, that you only want to check the whole library as a contributer, but not as a user. |
Well, an end-user would expect to be able to typecheck a file called README.agda :-) |
I agree, that is a reasonable expectation ;-) |
Some files import Everything files for no reason which can cause a headache when refactoring or renaming. It would be good to remove unnecessary imports of Everything and instead have more fine grained imports (for example if a file only uses 2-3 modules from Foundations there is no reason to import Foundations.Everything)
The text was updated successfully, but these errors were encountered: