Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up library #789

Merged
merged 26 commits into from
May 13, 2022
Merged

Clean up library #789

merged 26 commits into from
May 13, 2022

Conversation

thomas-lamiaux
Copy link
Contributor

@thomas-lamiaux thomas-lamiaux commented May 9, 2022

This pull request is a one week effort to clean the library

It will focus on :

  • Enforcing some of the naming convention (global and algebra) decided last week in past files.
    In particular the ones about import.
  • Renaming some object ill named.
  • Split of merge some files to enhanced clarity.

However, the goal is not to add any content to the library.
Don't hesitate to comment for instance to tell me to look at something

Description of the pull request :

  • Cleaning Polynomials
  • Renaming the PropositionalTruncation (description below)
  • Cleaning ZCohomology import, and some other files
  • Enforcing naming convention for Group and CommRing
  • Getting rid of open import Cubical.Foundations.Everything except in one paper in which the import are so messy that I preferred not to touch it. resolve Files should not import Everything files unless necessary #570
  • Rename Direct-Sum to DirectSum

@thomas-lamiaux thomas-lamiaux marked this pull request as draft May 9, 2022 21:28
@thomas-lamiaux thomas-lamiaux changed the title Enforcing name conventions + some clean up Clean up library May 10, 2022
@thomas-lamiaux
Copy link
Contributor Author

The proposition truncation was named ||||, ||, squash. It was done according to the HoTT Book.
However, for set and more it is indexed by the number for instance for set it is ||_||_2

The issue is that a numerous (like at least 50 and many complicated ones) are mixing more than one level of set truncation.
In which case, it is really better and clearer to always index them.
This actually what is already done in a bunch of files though with different notation.

Plus the notation for general truncation and proposition truncation is the same !
Some files are mixing the two. Sometimes even without renaming the prop one.
This makes files harder to read and even sometimes unreadable.

To solve this issue, I have rewritten textually (ie not with "renaming (X to Y)) the library with the convention where it is indexed in specific case so ||_||_1 etc...
The modification are without a doubt uninteresting.

@thomas-lamiaux thomas-lamiaux marked this pull request as ready for review May 12, 2022 16:53
Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think we should merge now, or is there some PR that should be merged first? @ecavallo @felixwellen

@mortberg
Copy link
Collaborator

Merging!

@mortberg mortberg merged commit b6fbca9 into agda:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files should not import Everything files unless necessary
2 participants