-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up library #789
Clean up library #789
Conversation
The index and the groups were at the same level. The should be at different one, for instance if the index is Nat, and the group something else
The proposition truncation was named ||||, ||, squash. It was done according to the HoTT Book. The issue is that a numerous (like at least 50 and many complicated ones) are mixing more than one level of set truncation. Plus the notation for general truncation and proposition truncation is the same ! To solve this issue, I have rewritten textually (ie not with "renaming (X to Y)) the library with the convention where it is indexed in specific case so ||_||_1 etc... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think we should merge now, or is there some PR that should be merged first? @ecavallo @felixwellen
Merging! |
This pull request is a one week effort to clean the library
It will focus on :
In particular the ones about import.
However, the goal is not to add any content to the library.
Don't hesitate to comment for instance to tell me to look at something
Description of the pull request :
open import Cubical.Foundations.Everything
except in one paper in which the import are so messy that I preferred not to touch it. resolve Files should not import Everything files unless necessary #570