Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and add a list of reviewers #885

Closed
felixwellen opened this issue Aug 10, 2022 · 3 comments
Closed

Update README and add a list of reviewers #885

felixwellen opened this issue Aug 10, 2022 · 3 comments
Assignees
@mortberg @felixwellen
Labels
documentation Documentation of the library, requests for comments

Comments

@felixwellen
Copy link
Collaborator

We need a list of reviewers, maybe together with some hints about the parts of the library they review. It would be good to update the README in general.
@felixwellen
Copy link
Collaborator Author

Maybe we could also say: If your PR is not assigned to someone in a couple of days, assign it to one of the reviewers..

@felixwellen felixwellen added the documentation Documentation of the library, requests for comments label Aug 10, 2022
@felixwellen
Copy link
Collaborator Author

Maybe that's a good overview, of the things to review:
https://github.com/agda/cubical/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+draft%3Afalse

felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: replace maintainer section in readme, by a reviewer section
34b2556
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: replace maintainer section in readme by a review-section
7b26b2c 
also: remove gitter-link, add a link with an overview of the PRs that need reviewing
@felixwellen felixwellen mentioned this issue Aug 11, 2022
Merged
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: update list of reviewers according to suggestions
496677e
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: Refer to expertise info in reviewer list
a4d1941
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: Expertise info for Axel and Max
88360a7
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: Table of reviewers instead of list, with more info
48a02cb
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: Table of reviewers instead of list, with more info
4b63c41
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: (Re-)organize README
94786b0
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885: Sort things in README by topic
a01d5af
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 11, 2022
@felixwellen
agda#885; Links to review queues
44ba855
felixwellen added a commit to felixwellen/cubical that referenced this issue Aug 15, 2022
@felixwellen
agda#885: more details on the discord server
ea33992
mortberg added a commit that referenced this issue Aug 21, 2022
@felixwellen @mortberg
#885: Update README, inform about reviewing (#887)
a0083ed 
* #885: replace maintainer section in readme by a review-section

also: remove gitter-link, add a link with an overview of the PRs that need reviewing

* better grammar

Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>

* Better description

Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>

* more info on reviewer Anders

Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>

* #885: update list of reviewers according to suggestions

* #885: Refer to expertise info in reviewer list

* #885: Expertise info for Axel and Max

* Grammar

* #885: Table of reviewers instead of list, with more info

* Typo

* #885: (Re-)organize README

* Less color noise

* #885: Sort things in README by topic

* #885; Links to review queues

* Add link to discord channel

* Add evans area of expertise

* #885: more details on the discord server

* Update README.md

Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>

* add material from hottest summer school

Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
@felixwellen
Copy link
Collaborator Author

Done with merging of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mortberg mortberg

@felixwellen felixwellen

Labels
documentation Documentation of the library, requests for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mortberg @felixwellen