Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizations of Hedberg's Theorem and Kraus' Lemma #333

Merged
merged 11 commits into from
Jun 8, 2020

Conversation

WorldSEnder
Copy link
Contributor

Introduces fixpoints, Kraus's Lemma and nullary relations found in "Generalizations of Hedberg's Theorem". We get the implications:

X ── ∣_∣ ─→ ∥ X ∥ ── populatedBy ─→ ⟪ X ⟫ ── notEmptyPopulated ─→ NonEmpty X

The proof of Kraus' lemma in particular is short compared to the version found in the originally associated agda code

A bit of bikeshedding over naming is expected, for example SplitSupport is currently aliased to HStable, etc. Suffix -≡ is supposed to mean "on all path spaces", as originally used in DecidableEq, but I personally find myself skipping over the suffix in some situations when reading the code.

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I had a few small comments and then I'll be happy to merge

Cubical/Functions/Fixpoint.agda Outdated Show resolved Hide resolved
Cubical/Functions/Fixpoint.agda Outdated Show resolved Hide resolved
Cubical/Foundations/Prelude.agda Show resolved Hide resolved
Cubical/Functions/Fixpoint.agda Outdated Show resolved Hide resolved
Cubical/Relation/Nullary/Base.agda Outdated Show resolved Hide resolved
Cubical/Relation/Nullary/Base.agda Outdated Show resolved Hide resolved
Cubical/Relation/Nullary/Properties.agda Outdated Show resolved Hide resolved
Cubical/Relation/Nullary/Base.agda Show resolved Hide resolved
@martinescardo
Copy link
Contributor

martinescardo commented Jun 8, 2020

It is better to use "split support" (apparently this terminology comes from (1-)topos theory, according to Mike Shulman) rather than hstable. The published version is in LMCS. https://lmcs.episciences.org/3217. The first proof that the type of fixed points of a weakly constant endomap is a proposition is due to Nicolai Kraus. Then other people, including Sattler, came up with simpler proofs (I think Sattler's proof is mentioned in our LMCS paper). I also have a simplified proof here: https://www.cs.bham.ac.uk/~mhe/HoTT-UF-in-Agda-Lecture-Notes/HoTT-UF-Agda.html#fix-is-subsingleton

@mortberg
Copy link
Collaborator

mortberg commented Jun 8, 2020

This looks good to me now! I'd be happy to merge as soon as Travis is done. Thanks for the contribution!

@mortberg mortberg merged commit 3f3b742 into agda:master Jun 8, 2020
@WorldSEnder WorldSEnder deleted the hedberg branch June 8, 2020 21:37
@MatthiasHu MatthiasHu mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants