Upper natural numbers #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded elements are preserved by the arithmetic operations
Also promote the rendered version in README w/ some adjectives stolen from the stdlib
# Conflicts: # Cubical/Algebra/CommMonoid/Base.agda # Cubical/Data/Nat/Order.agda
This reverts commit db795f0.
|
Ohno. That wasn't obsolete... I guess I should wake up first. |
|
Just in case there are any doubts: This PR still wants to be reviewed by @mortberg |
mortberg
requested changes
Jun 2, 2022
Cubical/Functions/Embedding.agda
Outdated
| @@ -425,3 +425,17 @@ module EmbeddingIdentityPrinciple {B : Type ℓ} {ℓ₁} (f g : Embedding B ℓ | |||
| f ≡ g | |||
| ■ | |||
| open EmbeddingIdentityPrinciple renaming (f≃g to _≃Emb_) using (EmbeddingIP) public | |||
There was a problem hiding this comment.
As far as I know, this is not code I wrote. Good question though.
There was a problem hiding this comment.
There is another instance of this in the file. Should I just change both?
There was a problem hiding this comment.
Yes, I guess that would be good
mortberg
approved these changes
Jun 7, 2022
|
Should be good to merge now! (travelling...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR constructs the upper natural numbers. They complete the naturals in some sense. For example, every collection of upper naturals constructively has a minimal element. The goal of this PR is to construct arithmetic operations on the upper natural numbers