Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the code compatible with the Agda branch issue4786 #606

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

nad
Copy link
Contributor

@nad nad commented Oct 20, 2021

This commit makes the code compatible with what might become a development version of Agda, without breaking compatibility with the current development version.

@nad
Copy link
Contributor Author

nad commented Oct 21, 2021

I disabled an example that type-checks very slowly, if at all, using the variant of Agda from the branch issue4786:

l3=l2++l1 : l3 ≡ l2 ++ᴰᴸ l1
l3=l2++l1 = refl

The slowdown seems to be caused by the changes on that branch. However, another recent development version of Agda (2.6.3-edd8334) also has trouble normalising the type of this example, unlike Agda 2.6.2. Perhaps it would make sense to figure out what, exactly, has made Agda slower.

@Saizan
Copy link
Contributor

Saizan commented Oct 21, 2021

Can you try adding --experimental-lossy-unification to that file? I believe the example is quite fast on a recent agda/master with that flag on.

@nad
Copy link
Contributor Author

nad commented Oct 21, 2021

That makes the example type-check quickly. However, Agda still has trouble normalising the goal type.

@Saizan
Copy link
Contributor

Saizan commented Oct 21, 2021

Yeah, I don't think it's reasonable to normalize the goal type here, you get quite large transports when you do.

@nad
Copy link
Contributor Author

nad commented Oct 21, 2021

It works fine with Agda 2.6.2.

@Saizan
Copy link
Contributor

Saizan commented Oct 21, 2021

That's because transports of indexed families are stuck in Agda 2.6.2.

@nad
Copy link
Contributor Author

nad commented Oct 21, 2021

OK, that explains the slowdown.

@ecavallo ecavallo merged commit 3e948f2 into master Nov 17, 2021
@ice1000 ice1000 deleted the issue4786 branch October 24, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants