Miscellaneous prelude cleaning #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
reviewed
Nov 13, 2021
Cubical/Foundations/Prelude.agda
Outdated
| @@ -286,12 +312,12 @@ module _ (P : ∀ y → x ≡ y → Type ℓ') (d : P x refl) where | |||
| -- Converting to and from a PathP | |||
|
|
|||
| module _ {A : I → Type ℓ} {x : A i0} {y : A i1} where | |||
| toPathP : transp (\ i → A i) i0 x ≡ y → PathP A x y | |||
| toPathP : transp A i0 x ≡ y → PathP A x y | |||
There was a problem hiding this comment.
Oh, no need to eta-expand anymore? @Saizan
There was a problem hiding this comment.
It's necessary to convert between lines and paths, but that's not happening here. Though it would need to expanded if I switch it to transport, since that takes a path. (Still it might be conceptually better to use transport?)
There was a problem hiding this comment.
Yeah, maybe nicer with transport?
mortberg
requested changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.