Examples of finite presentations of CommAlgebra's #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange... I have no good idea why it's so slow. Did you try making some parts abstract in order to isolate where the slowness is coming from? |
|
I'm not sure if I tried that. |
|
Hm. Now it seems to be a lot faster with an abstract 'makeFPAlgebra'... Thanks! |
…te-presentations # Conflicts: # Cubical/Algebra/CommAlgebra/FPAlgebra.agda
Isomorphism between spectrum (understood as zero locus of generators) and comm algebra homomorphisms.
Polynomial algebras are finitely presented
Improve notation
Spec Iso in FPAlgebra.agda
# Conflicts: # Cubical/Algebra/CommAlgebra/Base.agda # Cubical/Algebra/CommAlgebra/FPAlgebra.agda # Cubical/Algebra/CommAlgebra/FreeCommAlgebra/Properties.agda # Cubical/Algebra/CommAlgebra/Ideal.agda # Cubical/Algebra/CommAlgebra/Instances/Initial.agda # Cubical/Algebra/CommAlgebra/QuotientAlgebra.agda # Cubical/Algebra/CommRing/Ideal.agda
# Conflicts: # Cubical/Algebra/RingSolver/Examples.agda
This reverts commit befff8a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is, to introduce the notion of a finite presentation (instead of just the Prop 'finitelyPresented') and construct some basic finite presentations.
However, I'm stuck here because of a type checking speed issue. It seems that plugging the algebra
makeFPAlgebra n relationsintoCommAlgebraEquivis the cause of the slowdown. Maybe because the fields of this more complicated CommAlgebra get expanded? I don't know...