Only htmlize on master branch #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also promote the rendered version in README w/ some adjectives stolen from the stdlib
Closed
Merged
|
Nice, glad it actually seems to work in practice! |
|
Amazing! Thanks a lot for fixing this so quickly! |
|
Is there a reason why only the "Deploy to GitHub Pages" step was restricted to master, and not the "Htmlize cubical" step as well? |
Reason? Yes. Good? No. One may argue that it makes sense to check if it's possible to generate the html files as nobody said type checking guarantees it, but probably the truth is that I forgot to. |
|
😄 I think it's safe enough to assume the generation will work, so I'll make a new PR to add the check there. Looks like it will only save a minute or two of CI time, but we may as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also promote the rendered version in README w/ some adjectives (glorious, clickable) stolen from the stdlib.
Special thanks to @brendanzab