Use CommIdeal everywhere #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there still two definitions in the library or did you remove one of them completely? |
|
Well, it is a bit more complicated. One of the definitions just used the definition of Ideal in a Ring and I changed the definitions building on that, to use the other one. But in principle there could still be places, where we use Ideals in a CommRing instead of CommIdeals. I replaced everywhere I know of, though. |
|
@mzeuner @felixwellen Should this be merged? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two definitions of Ideals in commutative Rings. With @mzeuner, I decided to use 'CommIdeal'.
This PR implements this decision.