Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ ci ] Use the latest Agda but check cubical without NoEquivWhenSplitting warnings #697

Merged
merged 9 commits into from
Jan 20, 2022

Conversation

L-TChen
Copy link
Member

@L-TChen L-TChen commented Jan 19, 2022

The recent commit agda/agda@7bb14e0 breaks the CI, because the CI uses the releaed version 2.6.2 instead of the head of the master branch.

This PR tries to use a more recent version of Agda, although IMO it should use the most recent commit on master.

@L-TChen
Copy link
Member Author

L-TChen commented Jan 19, 2022

Urgh, I was misguided by the comment. The variable "AGDA_BRANCH" can only be a git branch or a tag, not a commit hash. Therefore, I propose to use the master branch of Agda to check the experimental version of the cubical library.

@L-TChen L-TChen force-pushed the bump-agda branch 6 times, most recently from a79cde6 to fdeefdc Compare January 20, 2022 03:21
@L-TChen L-TChen changed the title [ ci ] Use a more recent version of Agda instead of 2.6.2 [ ci ] Use the latest Agda but check cubical without NoEquivWhenSplitting warnings Jan 20, 2022
@L-TChen L-TChen merged commit d29db7f into agda:master Jan 20, 2022
@L-TChen L-TChen deleted the bump-agda branch January 20, 2022 12:09
@mortberg
Copy link
Collaborator

Do we really want the noNoEquivWhenSplitting flag to be set? Seems to pollute interaction in emacs

@mortberg
Copy link
Collaborator

Or wait, is this just introducing a typo and it should be NoEquivWhenSplitting? I'm very confused now...

@mortberg
Copy link
Collaborator

Oh no wait, I seem to not understand what this PR is supposed to be doing... Anyway, whatever it's doing seems to be introducing problems when working in emacs

mortberg added a commit that referenced this pull request Jan 24, 2022
…ivWhenSplitting` warnings (#697)"

This reverts commit d29db7f.
mortberg added a commit that referenced this pull request Jan 24, 2022
…ivWhenSplitting` warnings (#697)" (#701)

This reverts commit d29db7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants