Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polynomials over commutative rings added #714

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Conversation

AkermanRydbeck
Copy link
Contributor

Hello,

Here is an implementation of polynomials over commutative rings.

Cheers,
Carl

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tack så mycket!

Cubical/Algebra/CommRing/Instances/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials.agda Outdated Show resolved Hide resolved
@mortberg
Copy link
Collaborator

mortberg commented Mar 8, 2022

Oops, there is a clash for isZero: https://github.com/agda/cubical/runs/5465312974?check_suite_focus=true

@felixwellen
Copy link
Collaborator

You can just hide isZero on import in HornerForms.agda, then everything type checks.

@felixwellen
Copy link
Collaborator

And I am really happy we have this definition of polynomials now! And also that it is a set - I didn't know that it works this nicely.

@mortberg
Copy link
Collaborator

You can just hide isZero on import in HornerForms.agda, then everything type checks.

Yes, that should be the best solution. @AkermanRydbeck Can you do it please?

@mortberg
Copy link
Collaborator

And I am really happy we have this definition of polynomials now! And also that it is a set - I didn't know that it works this nicely.

Yes, I'm also very pleased that we managed to prove that it's a set without truncating. It's very nice to not have to deal with the truncation and to be able to eliminate into arbitrary types.

@AkermanRydbeck
Copy link
Contributor Author

Hello, glad you like it Felix.

isZero is hidden now.

/Carl

@mortberg mortberg merged commit e93eec9 into agda:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants