Don't claim cubical compiles with the latest agda development version #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it would make sense to say that cubical checks with whatever version of agda we use for testing. |
|
There was some discussion about this some time ago and the conclusion was that the library should compile on the latest official release of Agda. I think that's still the case or was there some new release that I'm not aware of? |
|
Ok, that's easier. Now I just want to change 'development' to 'official release'. |
felixwellen
changed the title
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
mortberg
approved these changes
Feb 10, 2022
|
I guess we can merge now without waiting for the CI to finish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme claims, that the library compiles with the latest version of agda. That is currently not true.
I made some quick changes to improve the situation.
What do you think @mortberg , @ecavallo ?