Remove some unused imports #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
approved these changes
Mar 10, 2022
|
@MatthiasHu to have an idea of the importance of the problem in the library, how many files do you thing you have tested ? |
|
I think I ran agda-unused on all .agda files (using find and xargs) and searched the output for "import". But agda-unused aborted immediately for many (most?) files because it hit something it didn't understand (possibly in dependencies of the respective module).
On 19 May 2022 18:02:59 CEST, Thomas Lamiaux ***@***.***> wrote:
***@***.*** to have an idea of the importance of the problem in the library, how many files do you thing you have tested ?
…
--
Reply to this email directly or view it on GitHub:
#732 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just removes some unused imports in various files.
Most of them were found by applying agda-unused to individual files (because it aborts with an error whenever it hits stuff like "record module instance applications"). I did not remove any
open import ... public.