Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ring solver work in more situations #754

Merged
merged 12 commits into from
May 2, 2022

Conversation

felixwellen
Copy link
Collaborator

This PR contains two small upgrades/fixes for the ring solver:

  • Adapt the approach from the monoid solver in the stdlib and also match structure which has the same normal form as the record field names of CommRingStr
  • Allow the argument of the solver macro to be more things - so far only a variable of type CommRing worked...

@kangrongji
Copy link
Contributor

kangrongji commented Apr 7, 2022

Maybe it's not the best place to ask... I've got problem when I applied ring solver to integers and put the question as this message on Agda Zulip. Do you know what the problem is? @felixwellen

@felixwellen
Copy link
Collaborator Author

To repeat what has been said on zulip here: This problem is now also fixed by the PR.

@felixwellen felixwellen marked this pull request as ready for review April 8, 2022 14:29
@ecavallo ecavallo merged commit 3ad5a9f into agda:master May 2, 2022
@felixwellen felixwellen deleted the stable-ringsolver branch May 12, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants