Fix ZGroup #786
Merged
Fix ZGroup #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index and the groups were at the same level. The should be at different one, for instance if the index is Nat, and the group something else
mortberg
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a weird reason, ZGroup et ZCommRing are not defined with the same definition.
Indeed someone took for the inverse
- x := 0 - xwhich is by definition0 + (- x)This poses a lot of trouble when mixing the two instances, indeed some 0 + X pop up sometimes, so one need to rewrite to add 0 to use presinv.
Plus it gets some proof more complicated as one always need to add.
So I am currently rewriting all the files using it