Principal ideal quotient fp #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasHu
reviewed
May 26, 2022
reverts only the options that were committed by accident This reverts commit 0285b361c55d86a9abaaa55915aaede8d9ba1be2.
|
@MatthiasHu thanks! |
|
The depency got replaced (by #816 ), and the replacement is merged. So this can be merged as well. |
|
The PR also contains a fruitless attempt to make things type check faster by using more copatterns. Since this is a rule anyway, I'll leave that as it is. I'll have a look if the PR checks with latest master and merge if yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joint work with @MatthiasHu :
Construct finite representaion of quotients by principal ideals.
Depends on #810 -> Draft