Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ℚ is a Field #826

Merged
merged 9 commits into from
May 27, 2022
Merged

ℚ is a Field #826

merged 9 commits into from
May 27, 2022

Conversation

kangrongji
Copy link
Contributor

@kangrongji kangrongji commented May 27, 2022

This PR shows is a field, using the QuoQ in library. The codes are basically copied from my own repo. I've always thought to move these codes to cubical library and it's time for .

@felixwellen felixwellen self-requested a review May 27, 2022 14:50
Cubical/Algebra/CommRing/Instances/QuoQ.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/QuoInt.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Field/Instances/QuoQ.agda Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/QuoInt.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/QuoInt.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/QuoInt.agda Outdated Show resolved Hide resolved
@felixwellen
Copy link
Collaborator

Thanks for the contribution! It is great to finally have the field of rationals...

@kangrongji
Copy link
Contributor Author

kangrongji commented May 27, 2022

If I am trying to apply solver to an explicit CommRing, for example:

f : ...
f = ...
  where
  helper : (x y : ℚCommRing .fst)  (x · y) · 1r ≡ 1r · (y · x)
  helper = solve ℚCommRing

It will cause errors. You can try it. So I have to pack up them in a module with abstract CommRing as parameter, then open it when needed.

@felixwellen
Copy link
Collaborator

If I am trying to apply solver to an explicit CommRing, for example:

f : ...
f = ...
  where
  helper : (x y : ℚCommRing .fst)  (x · y) · 1r ≡ 1r · (y · x)
  helper = solve ℚCommRing

It will cause errors. You can try it. So I have to pack up them in a module with abstract CommRing as parameter, then open it when needed.

Ah, yes - I know why, but that takes time to fix.

@kangrongji
Copy link
Contributor Author

kangrongji commented May 27, 2022

If I am trying to apply solver to an explicit CommRing, for example:

f : ...
f = ...
  where
  helper : (x y : ℚCommRing .fst)  (x · y) · 1r ≡ 1r · (y · x)
  helper = solve ℚCommRing

It will cause errors. You can try it. So I have to pack up them in a module with abstract CommRing as parameter, then open it when needed.

Ah, yes - I know why, but that takes time to fix.

Thanks! Please remember to @ me if you make it work.

@felixwellen
Copy link
Collaborator

I'll do my best...

@felixwellen felixwellen merged commit 1497d8b into agda:master May 27, 2022
@kangrongji kangrongji deleted the rationals branch May 27, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants