Characterization of Rezk Completion #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
requested changes
Aug 11, 2022
| @@ -70,6 +70,9 @@ module _ (C : Category ℓC ℓC') (D : Category ℓD ℓD') where | |||
| Iso→NatIso α .trans = α .fst | |||
| Iso→NatIso α .nIso = FUNCTORIso' _ (α .snd) | |||
|
|
|||
| NatIso→Iso : {F G : Functor C D} → NatIso F G → CatIso FUNCTOR F G | |||
There was a problem hiding this comment.
This is kind of a general comment, but wouldn't it be better if lemmas about CatIso would be called something with CatIso and not just Iso? So this would be NatIso→CatIso
There was a problem hiding this comment.
I change it to FUNCTORIso so it's more informative.
There was a problem hiding this comment.
(Look not very pretty though...)
There was a problem hiding this comment.
Yeah, the all caps names are not so nice... We should discuss naming convention for CT in an issue
There was a problem hiding this comment.
Ok. Then that's for it now.
mortberg
approved these changes
Aug 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the definition of Rezk completion, using its universal property, together with the characterization that a weak equivalence towards univalent category is a Rezk completion functor.
(see
Cubical.Categories.RezkCompletion.Base)The existence of Rezk completion will be given in a future PR.